Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Dockerfiles #3419

Merged
merged 1 commit into from
Mar 5, 2025
Merged

Simplify Dockerfiles #3419

merged 1 commit into from
Mar 5, 2025

Conversation

nazar-pc
Copy link
Member

@nazar-pc nazar-pc commented Mar 5, 2025

New version of rustup was released, now workaround is not needed and in fact it is possible to remove some more hacks. The only place where the version and components/targets are specified now is rust-toolchain.toml, which is picked up automatically.

Compiled locally without issues.

Code contributor checklist:

@nazar-pc nazar-pc requested review from vedhavyas and teor2345 March 5, 2025 21:22
@nazar-pc nazar-pc enabled auto-merge March 5, 2025 21:23
Copy link
Member

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nazar-pc nazar-pc added this pull request to the merge queue Mar 5, 2025
Merged via the queue into main with commit 66e2623 Mar 5, 2025
8 checks passed
@nazar-pc nazar-pc deleted the simplify-dockerfiles branch March 5, 2025 23:57
@vedhavyas
Copy link
Member

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants