Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ad-api): add mrm request #649

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

isamu-takagi
Copy link
Contributor

@isamu-takagi isamu-takagi commented Mar 10, 2025

Description

autowarefoundation/autoware#3096
Add MRM request API. The following deprecated APIs have been reworked as AD API because these are considered standard features and should be supported.

  • /api/external/set/emergency
  • /api/external/get/emergency

How was this PR tested?

None.

Notes for reviewers

None.

Effects on system behavior

None.

Signed-off-by: Takagi, Isamu <isamu.takagi@tier4.jp>
@isamu-takagi isamu-takagi self-assigned this Mar 10, 2025
Copy link

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

Comment on lines +61 to +62
| CANCEL | Cancel the MRM request associated with the specified user. |
| DELEGATE | Delegate the selection of MRM behavior to Autoware. |
Copy link
Member

@mitsudome-r mitsudome-r Mar 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We only have cancel and delegate as startegy.
Were there any considerations about selecting MRM behavior from an application?

In other words, if an application is triggering MRM through this API, then Autoware is not aware of the reason why it should be taking MRM behavior. Is it possible for Autoware to select the appropriate behavior in such situation?

If this is future work, that is okay, but we might want to state that in the description.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, I will consider to add strategies that vehicles achieve MRC as quickly as possible, as comfortable as possible, or etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants