Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phone logo in the header | Idea #2

Closed
juanmagdev opened this issue Mar 15, 2023 · 1 comment · Fixed by #3
Closed

Add phone logo in the header | Idea #2

juanmagdev opened this issue Mar 15, 2023 · 1 comment · Fixed by #3

Comments

@juanmagdev
Copy link

Thank you first of all for the CV template. This is a simple idea, I didn't see the need to make a pull request for the simple change. I find great to leave the phone number in the header. This is easy to do by including this in the class file:

\newcommand*{\phone}[1]{\def\comcv@phonenum{#1}}
...

\ifdefined\comcv@phonenum
    \ifx\comcv@phonenum\empty
        \def\comcv@phone{}
    \else
        \def\comcv@phone{\faPhone~\comcv@phonenum}
    \fi
    \else
    \def\comcv@phone{}
    \fi
...

\large\light\comcv@email~~\comcv@website~~\comcv@github~~\comcv@linkedin~~\comcv@phone
            \vspace{-\topsep}
            \horbar
            \vspace{-\topsep}
        \else
            \large\light\comcv@title
            \vspace{-\topsep}
            \horbar

            \comcv@email~~\comcv@website~~\comcv@github~~\comcv@linkedin~~\comcv@phone
            \vspace{-\topsep}
        \fi
        \else
            \large\light\comcv@email~~\comcv@website~~\comcv@github~~\comcv@linkedin~~\comcv@phone
            \vspace{-\topsep}
            \horbar
            \vspace{-\topsep}
        \fi
@avinal
Copy link
Owner

avinal commented Mar 20, 2023

Thanks @juanmagdev, for the suggestion. Once I find some spare time, I will consider this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants