Fix edge case having a value with numeric start and also a prefix #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
===========================================
- Coverage 100.00% 99.36% -0.64%
===========================================
Files 4 4
Lines 132 157 +25
Branches 30 39 +9
===========================================
+ Hits 132 156 +24
- Misses 0 1 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| expect(result).toBe('DB_1PASSWORD'); | ||
| expect(result).not.toBe('DB__1PASSWORD'); | ||
| expect(result.includes('__')).toBeFalsy(); |
There was a problem hiding this comment.
Correct me if I'm wrong but aren't the last 2 expect calls redundant?
Geethik07
force-pushed
the
geethikr_branch
branch
from
964a150 to
a849420
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Fixes #238
Description of changes:
Added an extra flag check to not include an extra underscore for the value starting with number if it already has a prefix.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.