-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter attributes neuron metrics #1262
Merged
aditya-purang
merged 13 commits into
aws:main
from
sam6134:filter-attributes-neuron-metrics
Aug 7, 2024
Merged
Filter attributes neuron metrics #1262
aditya-purang
merged 13 commits into
aws:main
from
sam6134:filter-attributes-neuron-metrics
Aug 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1262 +/- ##
==========================================
+ Coverage 57.58% 64.41% +6.82%
==========================================
Files 370 469 +99
Lines 17548 23679 +6131
==========================================
+ Hits 10105 15252 +5147
- Misses 6848 7677 +829
- Partials 595 750 +155 ☔ View full report in Codecov by Sentry. |
sam6134
reviewed
Jul 26, 2024
plugins/processors/gpuattributes/internal/metricFilters/gpumetricfilters.go
Show resolved
Hide resolved
plugins/processors/gpuattributes/internal/metricFilters/neuronMetricFilters.go
Outdated
Show resolved
Hide resolved
plugins/processors/gpuattributes/internal/awsneuron_metric_modifier.go
Outdated
Show resolved
Hide resolved
sam6134
previously approved these changes
Jul 30, 2024
movence
reviewed
Jul 31, 2024
plugins/processors/gpuattributes/internal/metricFilters/neuronMetricFilters.go
Outdated
Show resolved
Hide resolved
plugins/processors/gpuattributes/internal/metricFilters/neuronMetricFilters.go
Outdated
Show resolved
Hide resolved
plugins/processors/gpuattributes/internal/awsneuron_metric_checker.go
Outdated
Show resolved
Hide resolved
plugins/processors/gpuattributes/internal/awsneuron_metric_checker.go
Outdated
Show resolved
Hide resolved
movence
reviewed
Aug 2, 2024
plugins/processors/gpuattributes/internal/awsneuron_metric_checker.go
Outdated
Show resolved
Hide resolved
sam6134
approved these changes
Aug 7, 2024
Merged
movence
approved these changes
Aug 7, 2024
mitali-salvi
added a commit
that referenced
this pull request
Aug 8, 2024
This reverts commit 55a3d88.
This was referenced Aug 8, 2024
Merged
mitali-salvi
added a commit
to mitali-salvi/amazon-cloudwatch-agent
that referenced
this pull request
Dec 2, 2024
This reverts commit 55a3d88.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
We saw that the EMF logs for neuron were having too many bytes causing an inflation in bills. This was caught by our monitoring and while investigating we saw some attributes which were redundant and could've been filtered out making the logs a bit lighter.
Description of changes
This PR has 2 major changes for the GPU processor:
Tests
Tested in eks playground cluster
Requirements
make fmt
andmake fmt-sh
: donemake lint
: done