Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue
TestLogsFileRecreate()
intermittently fails on Windows OS.example: https://github.com/aws/amazon-cloudwatch-agent/runs/4156147013?check_suite_focus=true
There are actually 2 issues.
First is that there is a
for
loop that will does not end until Go does apanic
.Second, the delay between deleting the monitored temp file and recreating it is a fixed 100 ms.
These 2 changes are minimally required.
Description of changes
The loop will timeout after 10 seconds if the LogSrc is not found, instead of
Panic
after 10 minutes.The fixed delay between deleting and recreating the temp file has been increased from 100ms to 1 second.
I added some info messages to describe what the test is doing.
I was just going to add code comments, but logging what the test is doing makes it easier to correlate with what the functions being tested are doing and correlate with if/when errors occur.
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests