feat(opensearchservice): ip address type for domain #28497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
distinguished-contributor
github-actions
bot
added
effort/medium
aws-cdk-automation
added
the
pr/needs-community-review
WinterYukky
approved these changes
Dec 27, 2023
aws-cdk-automation
added
pr/needs-maintainer-review
kaizencc
approved these changes
Dec 28, 2023
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
paulhcsun
pushed a commit
to paulhcsun/aws-cdk
that referenced
this pull request
Jan 5, 2024
This PR adds a `ipAddressType` property for `Domain`. Closes aws#28436. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
1 task
mergify bot
pushed a commit
that referenced
this pull request
Mar 3, 2025
### Issue # (if applicable) Closes #32553. ### Reason for this change #32553. Recently as a part of coordinator node project we introduced a new parameter called NodeOptions, currently its part of L1 construct but we wanted it to be part of L2 construct and that is why raising this PR. ### Description of changes The code is very much similar to - #28497 and follows all standard practices in the repository. ### Describe any new or updated permissions being added N/A ### Description of how you validated changes Unit tests - ``` > yarn test aws-opensearchservice yarn run v1.22.22 $ jest aws-opensearchservice PASS aws-opensearchservice/test/log-group-resource-policy.test.ts PASS aws-opensearchservice/test/opensearch-access-policy.test.ts PASS aws-opensearchservice/test/domain.test.ts (5.687 s) =============================== Coverage summary =============================== Statements : 43.87% ( 9437/21508 ) Branches : 23.09% ( 2037/8820 ) Functions : 25.62% ( 1229/4796 ) Lines : 44.6% ( 9285/20816 ) ================================================================================ Jest: "global" coverage threshold for statements (55%) not met: 43.87% Jest: "global" coverage threshold for branches (35%) not met: 23.09% Test Suites: 3 passed, 3 total Tests: 1326 passed, 1326 total Snapshots: 0 total Time: 7.538 s ``` Integration Tests - ``` Running in parallel across regions: us-east-1, us-east-2, us-west-2 Running test /Users/dubesar/aws-cdk/packages/@aws-cdk-testing/framework-integ/test/aws-opensearchservice/test/integ.opensearch.nodeoptions.js in us-east-1 SUCCESS aws-opensearchservice/test/integ.opensearch.nodeoptions-OpenSearchInteg/DefaultTest 658.125s NO ASSERTIONS Test Results: Tests: 1 passed, 1 total ✨ Done in 659.62s. ``` Snapshots is also generated as a part of integration tests ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) YES ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
ipAddressTypeproperty forDomain.Closes #28436.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license