Add supported Rust versions to README #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcoh
reviewed
Jun 23, 2021
There was a problem hiding this comment.
can you also add a badge to the top of the README? Something like: https://img.shields.io/badge/msrv-1.52.1-red
README.md
Outdated
| @@ -75,6 +75,10 @@ If you are interested in contributing to the new AWS SDK for Rust, please take a | |||
|
|
|||
| This alpha SDK currently does not provide support for every AWS service. You can see all the services currently supported on [AWS_SERVICES_SUPPORTED](AWS_SERVICES_SUPPORTED.md) | |||
|
|
|||
| ## Supported Rust Versions | |||
|
|
|||
| The SDK currently requires a minimum of Rust 1.51.0, and is not guaranteed to build on compiler versions earlier than that. While we are still in alpha, we will be keeping the minimum compiler version two releases behind the latest stable release (so if the latest stable is 1.53, we will be on 1.51), but we are not making any guarantees around this at present. Increases in minimum required Rust version will be called out in the Release Notes for new releases of the SDK. | |||
There was a problem hiding this comment.
it's actually 1.52.0 because of a usage of some doc lints. We can roll it back if we want
There was a problem hiding this comment.
I'd include the string MSRV somewhere, that's what I'd search for if I was trying to figure this out
rcoh
approved these changes
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #129.
Fixes #128.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.