Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license check job to runner #74

Merged
merged 1 commit into from
Jul 2, 2021
Merged

Conversation

jpculp
Copy link
Contributor

@jpculp jpculp commented Jul 2, 2021

Description of changes:

Adds a check-licenses job to the GitHub Actions runner, which leverages cargo-deny to verify that all crates and their dependencies have compatible licenses.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Adds a `check-licenses` job to the GitHub Actions runner, which
leverages `cargo-deny` to verify that all crates and their dependencies
have compatible licenses.
@jpculp jpculp requested review from tjkirch and webern July 2, 2021 17:03
Copy link
Contributor

@webern webern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will be slow without caching, but we can deal with that if it becomes an issue.

Copy link
Contributor

@tjkirch tjkirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Building cargo-deny is the longest step in the checks, so I think we should do caching (like tough) as a follow-up.

@jpculp jpculp merged commit c4e378a into awslabs:develop Jul 2, 2021
@jpculp jpculp deleted the add-cargo-deny branch July 2, 2021 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants