Revert "Disable xattrs by default" #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
go
This reverts commit 2a70d12 and some extra reverts related to it. Signed-off-by: David Son <davbson@amazon.com>
sondavidb
force-pushed
the
fix-xattrs-volume
branch
from
72d76b1 to
feecbee
Compare
pendo324
approved these changes
Jul 17, 2024
austinvazquez
approved these changes
Jul 17, 2024
swagatbora90
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Related: #1314
Description of changes:
This reverts commit 2a70d12 and some extra reverts related to it. This is due to a bug we have where containers fail to start if the image has a layer with xattrs disabled and a volume mount is present in said layer.
This ideally gets fixed upstream, but as that might take a while to propagate into nerdctl, for now we should revert this commit so that this is an opt-in behavior instead of a default one.
Testing performed:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.