-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ViewPropTypes has been deprecated in React Native #244
Comments
since |
@vitalyiegorov you can also provide a pull request to get this quickly fixed :) |
Replaces ViewPropTypes.style with PropTypes.object Addresses bartgryszko#244
replaces ViewPropTypes.style with PropTypes.object addresses bartgryszko#244
I believe this is now resolved. |
@markusl Could you release the new version with this fix, please? |
@lavor To work it on react-native-web you need also https://github.com/bakerface/react-native-svg-web In CircuralProgress still got something like that for version 1.3.6 |
#247 it works well on my project. |
Using React Native 0.62.2
PropTypes has been deprecated and will be removed react-native-community/discussions-and-proposals#29
We are using this package with React native web and after 0.12 release it throws an error:
node_modules/react-native-circular-progress/src/CircularProgress.js Attempted import error: 'ViewPropTypes' is not exported from 'react-native-web/dist/index'.
As they have already removed the
PropTypes
from their exports.a possible npm script fix:
"fix:react-native-circular-progress": "sed -e \"s/ViewPropTypes.style,/PropTypes.object,/g\" -i.bak ./node_modules/react-native-circular-progress/src/CircularProgress.js",
The text was updated successfully, but these errors were encountered: