Windows: jasmine_node_test uses nodejs_test_macro #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the jasmine_node_test() rule on Windows when tested with Bazel's Windows-native test wrapper (see bazelbuild/bazel#5508). jasmine_node_test now uses nodejs_test_macro, so on Windows it depends on the sh_test (whose output is an .exe file) and not on nodejs_test (whose output is a .sh file). The native test wrapper can't test nodejs_test directly because it can't create a subprocess for an .sh file.
laszlocsomor
requested review from
alexeagle,
gregmagolan and
kyliau
as code owners
|
I'll fix the test failures and ping this thread. |
laszlocsomor
changed the title
Change the file npm_package.spec.js was locating, from "test.sh" to just "test".
laszlocsomor
changed the title
|
All fixed. |
|
Ping. |
kyliau
approved these changes
Apr 18, 2019
|
We should figure out how to remove those macros altogether. They are only there to get the native windows exe - the indirection has cost us before. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows: jasmine_node_test uses nodejs_test_macro
Fix the jasmine_node_test() rule on Windows when
tested with Bazel's Windows-native test wrapper
(see bazelbuild/bazel#5508).
jasmine_node_test() now uses nodejs_test_macro()
instead of nodejs_test(). This changes the test's
executable from a Bash script to a native Windows
binary, so the rule can be tested using Bazel's
new Windows-native test wrapper.
The default test wrapper is a Bash script, which
could run shell scripts as subprocesses so it
could test nodejs_test() directly.
The new test wrapper is a native C++ binary that
can only run native Windows binaries. (But it does
not require Bash, see bazelbuild/bazel#5508.)
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Tests in
//internal/e2e/fine_grained_deps:*fail with Bazel 0.25.0rc2 and--incompatible_windows_native_test_wrapper. (Flag info: bazelbuild/bazel#6622)Bazel output:
What is the new behavior?
Those tests pass now.
Does this PR introduce a breaking change?
Other information