Skip to content

Commit

Permalink
C++: Make cc_binary's linking go through CcLinkingHelper.
Browse files Browse the repository at this point in the history 
CcLinkingHelper has new functionality to support transitive linking. This is
not exposed to Starlark yet.

GitHub issue #4570

This was rolled back because in the refactoring I started passing headers to the linking action that were not passed before. These headers have mistakes and cannot be pre-processed, so when they were passed as inputs to the linking action, the compilation action was executed whereas before it wasn't.

Fixed and added test to make sure the behavior is the same as before.

RELNOTES:none
PiperOrigin-RevId: 214785687
  • Loading branch information
@oquenchil
oquenchil authored and Copybara-Service committed Sep 27, 2018
1 parent 2334a56 commit 93b1912
Show file tree
Hide file tree
Showing 6 changed files with 388 additions and 236 deletions.
Loading

0 comments on commit 93b1912

Please sign in to comment.