Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.2.0] Stringify Labels in display form in Args #21826

Closed
bazel-io opened this issue Mar 27, 2024 · 2 comments · Fixed by #21956
Closed

[7.2.0] Stringify Labels in display form in Args #21826

bazel-io opened this issue Mar 27, 2024 · 2 comments · Fixed by #21956
Milestone
7.2.0 release blo...

Comments

@bazel-io
Copy link
Member

Forked from #21702
@bazel-io bazel-io added this to the 7.2.0 release blockers milestone Mar 27, 2024
@bazel-io
Copy link
Member Author

bazel-io commented Apr 9, 2024

Cherry-pick was attempted but there were merge conflicts in the following file(s). Please resolve manually.

src/main/java/com/google/devtools/build/lib/analysis/CachingAnalysisEnvironment.java
src/main/java/com/google/devtools/build/lib/analysis/starlark/Args.java
src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkActionFactory.java
src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkCustomCommandLine.java
src/test/java/com/google/devtools/build/lib/analysis/starlark/StarlarkCustomCommandLineTest.java

cc: @bazelbuild/triage

@bazelbuild bazelbuild deleted a comment from bazel-io Apr 10, 2024
@fmeum fmeum mentioned this issue Apr 10, 2024
Merged
@iancha1992
Copy link
Member

iancha1992 commented Apr 10, 2024 •
edited
Loading

Cherry-picked in #21956 by @fmeum

github-merge-queue bot pushed a commit that referenced this issue Apr 10, 2024
@fmeum
[7.2.0] Cherry-pick label strinigification changes (#21956)
40fa762 
This cherry-picks:
* Stringify `Label`s in display form in `Args`
(9d3a8b0)
* Show display form labels in `java_*` buildozer fixups
(1c99866)

Fixes #21948 
Fixes #21826
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.2.0 release blockers
Development

Successfully merging a pull request may close this issue.

[7.2.0] Cherry-pick label strinigification changes fmeum/bazel
2 participants
@bazel-io @iancha1992