[6.1.0]Rollback #14510 because it causes remote test execution to fail #17311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the parent process is run as a different user to the test itself (as can happen in some remote build environments, such as buildbarn) using `kill -0 $PPID` fails, causing the test to be prematurely killed. This PR rolls back the (nicer, cleaner, not always working) fix and replaces it with the (less nice, less clean, more often working) check that was there before. Tested with a local build against buildbarn. Closes #17147. PiperOrigin-RevId: 500691976 Change-Id: Ife55db5c1ed88d40ba502257ce9b679b04eeb179
|
What's the difference between this and #17210? |
Hi @larsrc-google! This is the forked issue. Once I get approval from you then I will go ahead & merge this PR,Following I can close the forked issue. Thanks! |
|
|
I'm confused, but it's certainly OK to merge. |
|
larsrc-google
approved these changes
Jan 25, 2023
This was referenced May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the parent process is run as a different user to the test itself (as can happen in some remote build environments, such as buildbarn) using
kill -0 $PPIDfails, causing the test to be prematurely killed.This PR rolls back the (nicer, cleaner, not always working) fix and replaces it with the (less nice, less clean, more often working) check that was there before.
Tested with a local build against buildbarn.
Closes #17147.
PiperOrigin-RevId: 500691976
Change-Id: Ife55db5c1ed88d40ba502257ce9b679b04eeb179