Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry on javax.net.ssl.SSLException ... BAD_DECRYPT #19321

Closed
wants to merge 1 commit into from
Closed

Retry on javax.net.ssl.SSLException ... BAD_DECRYPT #19321

wants to merge 1 commit into from

Conversation

coeuvre
Copy link
Member

@coeuvre coeuvre commented Aug 24, 2023

Fixes #18965.

@coeuvre coeuvre requested a review from a team as a code owner August 24, 2023 09:47
@coeuvre coeuvre requested a review from tjgq August 24, 2023 09:47
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Remote-Exec Issues and PRs for the Execution (Remote) team labels Aug 24, 2023
@brentleyjones
Copy link
Contributor

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Aug 24, 2023
@iancha1992
Copy link
Member

@bazel-io fork 6.4.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Aug 24, 2023
@bazel-io bazel-io mentioned this pull request Aug 24, 2023
Closed
@coeuvre coeuvre added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Aug 25, 2023
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Aug 25, 2023
@iancha1992
Copy link
Member

iancha1992 commented Aug 25, 2023 •
edited
Loading

@brentleyjones @coeuvre @tjgq We may need another commit before we cherry-pick this to release-6.4.0. RETRIABLE_HTTP_ERRORS does not exist in the current release-6.4.0 branch. So we'll need a commit that introduces this variable in the src/main/java/com/google/devtools/build/lib/remote/RemoteModule.java file.

cc: @bazelbuild/triage

@coeuvre coeuvre deleted the retry-http-ssl-error branch August 28, 2023 08:42
@coeuvre
Copy link
Member Author

coeuvre commented Aug 28, 2023

That's sad :(. I need to check whether it's feasible to cherry-pick the dependencies.

coeuvre added a commit to coeuvre/bazel that referenced this pull request Aug 28, 2023
@coeuvre
Retry on javax.net.ssl.SSLException ... BAD_DECRYPT
25efa62 
Fixes bazelbuild#18965.

Closes bazelbuild#19321.

PiperOrigin-RevId: 560034218
Change-Id: I19a595fb6ba8e0a4cf46f25b0b33807282ca586c
@iancha1992
Copy link
Member

The changes in this PR have been included in Bazel 6.4.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjgq tjgq tjgq approved these changes

Assignees
No one assigned
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bazel crashes with javax.net.ssl.SSLException ... BAD_DECRYPT
5 participants
@coeuvre @brentleyjones @iancha1992 @tjgq @bazel-io