Allow genrule dependencies in cc_ build rules. #4875
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is going to be contentious. On one hand, power and expressiveness, and on the other, non-hermetic builds. I have some rules that need to depend on linker scripts (which are allowed dependencies), but those scripts are generated by a genrule that includes some symbols or not depending on config_settings interpreted through select expressions. Will this ever be allowed? If not, can we get some kind of provider for a Skylark rule to apply as some kind of "yes, I accept the risks and responsibilities of being a cc_ rule dependency."?
|
Hi Dionna, I see you understand the tradeoffs. So it won't be surprising that I don't want to allow C++ rules to depend on genrules, that's just too much rope. But we are currently working on #4570 that will enable you to write your own almost cc_library/cc_binary that will do what you need. I'll close this PR now, you can comment on #4570 if you want to continue the discussion. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is going to be contentious. On one hand, power and expressiveness, and on the other, non-hermetic builds.
I have some rules that need to depend on linker scripts (which are allowed dependencies), but those scripts are generated by a genrule that includes some symbols or not depending on config_settings interpreted through select expressions. Since it is a genrule doing this, Bazel disallows it.
Will this ever be allowed? If not, can we get some kind of provider for a Skylark rule to apply as some kind of "yes, I accept the risks and responsibilities of being a cc_ rule dependency."?