Teach bazelisk.py about .bazeliskrc #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwnimmer-tri
force-pushed
the
python-dotfile-enhancements
branch
from
4ec0d7c to
c5ea229
Compare
jwnimmer-tri
force-pushed
the
python-dotfile-enhancements
branch
2 times, most recently
from
0763f0b to
274c2b4
Compare
jwnimmer-tri
added a commit
to jwnimmer-tri/drake
that referenced
this pull request
Aug 26, 2023
This is a copy as of bazelbuild/bazelisk#494. In a future commit, we'll add infrastructure to keep our copy in sync. Co-authored-by: Akshay Shah <akshayjshah@users.noreply.github.com> Co-authored-by: Alex Ford <a.sewall.ford@gmail.com> Co-authored-by: Andrew Z Allen <me@andrewzallen.com> Co-authored-by: Clint Harrison <243356+clintharrison@users.noreply.github.com> Co-authored-by: Coeuvre <coeuvre@gmail.com> Co-authored-by: Florian Weikert <fwe@google.com> Co-authored-by: Jeremy Maitin-Shepard <jeremy@jeremyms.com> Co-authored-by: Jingwen Chen <jingwen@google.com> Co-authored-by: Jonathan Bluett-Duncan <jbluettduncan@gmail.com> Co-authored-by: Marcel Hlopko <hlopko@google.com> Co-authored-by: Markus Padourek <markus.padourek@ecosia.org> Co-authored-by: Matt Passell <mpassell@grovehillsoftware.com> Co-authored-by: Natalie Pendragon <natalie.pendragon@gmail.com> Co-authored-by: Philipp Wollermann <philipp.wollermann@gmail.com> Co-authored-by: Philipp Wollermann <philwo@google.com> Co-authored-by: Robbert van Ginkel <robbert@vanginkels.com> Co-authored-by: rpwoodbu <spam_github@fairfax.mybox.org> Co-authored-by: Sergey Balabanov <sbalabanov@hotmail.com> Co-authored-by: Zhongpeng Lin <zplin@uber.com>
jwnimmer-tri
added a commit
to jwnimmer-tri/drake
that referenced
this pull request
Aug 26, 2023
This is a copy as of bazelbuild/bazelisk#494. In a future commit, we'll add infrastructure to keep our copy in sync. Co-authored-by: Akshay Shah <akshayjshah@users.noreply.github.com> Co-authored-by: Alex Ford <a.sewall.ford@gmail.com> Co-authored-by: Andrew Z Allen <me@andrewzallen.com> Co-authored-by: Clint Harrison <243356+clintharrison@users.noreply.github.com> Co-authored-by: Coeuvre <coeuvre@gmail.com> Co-authored-by: Florian Weikert <fwe@google.com> Co-authored-by: Jeremy Maitin-Shepard <jeremy@jeremyms.com> Co-authored-by: Jingwen Chen <jingwen@google.com> Co-authored-by: Jonathan Bluett-Duncan <jbluettduncan@gmail.com> Co-authored-by: Marcel Hlopko <hlopko@google.com> Co-authored-by: Markus Padourek <markus.padourek@ecosia.org> Co-authored-by: Matt Passell <mpassell@grovehillsoftware.com> Co-authored-by: Natalie Pendragon <natalie.pendragon@gmail.com> Co-authored-by: Philipp Wollermann <philipp.wollermann@gmail.com> Co-authored-by: Philipp Wollermann <philwo@google.com> Co-authored-by: Robbert van Ginkel <robbert@vanginkels.com> Co-authored-by: rpwoodbu <spam_github@fairfax.mybox.org> Co-authored-by: Sergey Balabanov <sbalabanov@hotmail.com> Co-authored-by: Zhongpeng Lin <zplin@uber.com>
jwnimmer-tri
added a commit
to jwnimmer-tri/drake
that referenced
this pull request
Aug 28, 2023
This is a copy as of bazelbuild/bazelisk#494. In a future commit, we'll add infrastructure to keep our copy in sync.
jwnimmer-tri
added a commit
to jwnimmer-tri/drake
that referenced
this pull request
Aug 28, 2023
This is a copy as of bazelbuild/bazelisk#494. In a future commit, we'll add infrastructure to keep our copy in sync.
jwnimmer-tri
added a commit
to jwnimmer-tri/drake
that referenced
this pull request
Aug 29, 2023
This is a copy as of bazelbuild/bazelisk#494. In a future commit, we'll add infrastructure to keep our copy in sync.
jwnimmer-tri
force-pushed
the
python-dotfile-enhancements
branch
3 times, most recently
from
2e030c9 to
28f12f1
Compare
|
Hi team. Is there anything I can do to help move this forward? I just fixed the merge conflict errors with a rebase. |
|
Hi team. Is there anything I can do to help move this forward? |
jwnimmer-tri
force-pushed
the
python-dotfile-enhancements
branch
from
28f12f1 to
0621917
Compare
|
Hi team. Is there anything I can do to help move this forward? All tests are passing. |
|
@jwnimmer-tri just wondering - is this still relevant? (I didn't take a look yet) |
jwnimmer-tri
force-pushed
the
python-dotfile-enhancements
branch
from
0621917 to
fd67afb
Compare
|
Yes, I believe so. I just rebased and re-tested locally and all tests passed. |
fweikert
reviewed
Jul 23, 2024
meteorcloudy
added
the
awaiting-user-response
jwnimmer-tri
force-pushed
the
python-dotfile-enhancements
branch
from
847bbc5 to
8dbaff5
Compare
jwnimmer-tri
force-pushed
the
python-dotfile-enhancements
branch
from
8dbaff5 to
09ed135
Compare
|
This should be ready for re-review now. |
|
The label "awaiting-user-response" is no longer accurate -- I have responded. |
fweikert
approved these changes
Nov 25, 2024
|
Thank you! |
|
Gracias |
|
`` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for suggesting (but not requiring) a bazel version using the bazeliskrc dotfile.