Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BCR reviewer: Add diff_module action type #2158

Merged
merged 9 commits into from
Jan 17, 2025
Merged

BCR reviewer: Add diff_module action type #2158

merged 9 commits into from
Jan 17, 2025

Conversation

meteorcloudy
Copy link
Member

@meteorcloudy meteorcloudy commented Jan 15, 2025 •
edited
Loading

This action will diff new module versions in a BCR PR against its previous version. Making it much easier to review changes between module versions.

Test runs:

@meteorcloudy
Copy link
Member Author

FYI @fmeum

Wyverald
Wyverald approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@Wyverald Wyverald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some nits. otherwise this looks awesome! thanks :)))

@meteorcloudy meteorcloudy merged commit abb92bb into master Jan 17, 2025
7 checks passed
@meteorcloudy meteorcloudy deleted the diff_module branch January 17, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyverald Wyverald Wyverald approved these changes

@fweikert fweikert Awaiting requested review from fweikert fweikert is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meteorcloudy @Wyverald