Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rules_nodejs to 0.42.3 #1324

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Update rules_nodejs to 0.42.3 #1324

merged 1 commit into from
Dec 17, 2019

Conversation

gregmagolan
Copy link
Contributor

No description provided.

@gregmagolan gregmagolan force-pushed the rule_nodejs_0.42.3 branch 2 times, most recently from 0316a10 to 33a7cbf Compare December 17, 2019 08:47
@gregmagolan gregmagolan marked this pull request as ready for review December 17, 2019 08:57
@nlopezgi
Copy link
Contributor

/gcbrun

@nlopezgi nlopezgi merged commit 8c28cb9 into bazelbuild:master Dec 17, 2019
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gregmagolan, nlopezgi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nlopezgi nlopezgi mentioned this pull request Dec 17, 2019
Closed
@alexeagle
Copy link
Contributor

oh awesome thank you!
@nlopezgi do you have an idea when you'll cut a rules_docker release? Since this is in, it lets us remove the old API for our 1.0 release which we're hoping to cut before the holidays. But I don't want rules_nodejs users to trip over their nodejs_image rules if there's no rules_docker release that works with our 1.0.

@gregmagolan
Copy link
Contributor Author

Thanks @nlopezgi !

@nlopezgi
Copy link
Contributor

Release 0.13.0 is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlopezgi nlopezgi nlopezgi approved these changes

@smukherj1 smukherj1 Awaiting requested review from smukherj1 smukherj1 is a code owner

@alex1545 alex1545 Awaiting requested review from alex1545

Assignees

@nlopezgi nlopezgi

Labels
approved cla: yes lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gregmagolan @nlopezgi @k8s-ci-robot @alexeagle @googlebot