Apply default cpu based on target Apple platform #899
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thii
force-pushed
the
thi/apply-default-cpu-based-on-target-apple-platform
branch
from
3d04948 to
f03cf38
Compare
If `--apple_platform_type` is passed but `--cpu` or
`--{ios_multi|watchos|tvos|macos}_cpus` is not passed, apply a transition
to change the `--cpu` flag to a default `cpu` based on the target
platform.
The transitions.bzl was copied from
https://github.com/bazelbuild/bazel/blob/5604779c98edee9bedbe668ca72f2aa1ffb4cf2e/src/main/starlark/builtins_bzl/common/objc/transitions.bzl#L1
with the `//command_line_option:incompatible_enable_apple_toolchain_resolution`
flag removed to continue supporting Bazel 5.x.
thii
force-pushed
the
thi/apply-default-cpu-based-on-target-apple-platform
branch
from
f03cf38 to
2e8e627
Compare
thii
requested review from
BalestraPatrick,
brentleyjones,
keith and
segiddins
as code owners
thii
deleted the
thi/apply-default-cpu-based-on-target-apple-platform
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
--apple_platform_typeis passed but--cpuor--{ios_multi|watchos|tvos|macos}_cpusis not passed, apply a transition to change the--cpuflag to a defaultcpubased on the target platform.The transitions.bzl was copied from https://github.com/bazelbuild/bazel/blob/5604779c98edee9bedbe668ca72f2aa1ffb4cf2e/src/main/starlark/builtins_bzl/common/objc/transitions.bzl#L1 with the
//command_line_option:incompatible_enable_apple_toolchain_resolutionflag removed to continue supporting Bazel 5.x.Fixes #897