New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix implicitly nullable params #340

Closed

kamil-tekiela wants to merge 1 commit into beberlei:master from kamil-tekiela:Fix-implicitly-nullable-params

kamil-tekiela commented Mar 21, 2024 •

edited

Loading

Could not run composer assert:cs-fix due to outdated config
composer assert:generate-docs run and it picked up one unrelated change. It looks like the documented method omits the nullability of untyped params.

This is because of the deprecation in PHP 8.4 https://wiki.php.net/rfc/deprecate-implicitly-nullable-types It throws a lot of deprecation notices in PHPUnit tests.


          Fix implicitly nullable params

864e155

Owner

beberlei commented Apr 23, 2024

Fixed by #337

beberlei closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet