-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to exclude specific directories #50
Add option to exclude specific directories #50
Conversation
@jeff-matthews Thanks for this. I moved things around a bit to better conform to Ruby style, and added tests. I believe things should now be working as expected. Mind giving it another try? If things look good, if you wouldn't mind documenting the new behavior in the README, I believe this PR can be merged and I can cut a new release. |
Thanks @benbalter! I pulled your changes, but I'm getting an error:
|
@jeff-matthews sorry about that. You actually found a long-standing bug, and I think a long-standing mistake in the Jekyll documentation. I'll open an issue upstream, but things should be fixed here and I can build locally outside of tests. Mind giving it another try? |
@benbalter, works like a charm! Generation time in my particular project went from ~670 seconds to ~4 seconds, which is a huge improvement. I'll update the README with the new behavior and push those changes to this PR. |
Congrats on getting your first pull request to Jekyll Relative Links merged! Without amazing humans like you submitting pull requests, we couldn’t run this project. You rock! 🎉 |
Thanks @jeff-matthews! |
Thank you @benbalter!!! |
Fixes #49
I added some logic to the
generator.rb
file to exclude directories specified in a project's_config.yml
file like so:The plugin still seems to be processing all directories though because I don't see confirmation in the console that the specified directories have been excluded when it gets to the
jekyll-relative-links
stage: