Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic on failure in scene example #17812

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

rparrett
Copy link
Contributor

Objective

Fixes #17810

Y'all picked the option I already implemented, yay.

Solution

Add a system that panics if the load state of an asset is Failed.

Testing

cargo run --example scene

  • Tested with valid scene file
  • Introduced a syntax error in the scene file
  • Deleted the scene file

@alice-i-cecile alice-i-cecile added C-Examples An addition or correction to our examples C-Testing A change that impacts how we test Bevy or how users test their apps A-Scenes Serialized ECS data stored on the disk labels Feb 11, 2025
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Feb 11, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Feb 11, 2025
Merged via the queue into bevyengine:main with commit 7398d33 Feb 11, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Scenes Serialized ECS data stored on the disk C-Examples An addition or correction to our examples C-Testing A change that impacts how we test Bevy or how users test their apps S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make scene example panic if it fails to load
3 participants