Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Golden Lepharist Insignia drops in Eltnen #52

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

sky1683589933
Copy link
Contributor

Add missing drops for eltnen

Add missing drops for eltnen
Copy link
Member

@neon-dev neon-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to implement the drops similar to the ones in Heiron, if possible.
You can use the //zone command to list all zones at your current position.
Please check and let me know what you think.

@sky1683589933
Copy link
Contributor Author

sky1683589933 commented Feb 5, 2025

I don't think it's necessary to modify it to group drop. If you want to modify it, you also need to check the accuracy of the group members, because this item is only drop by the NPCs I listed, and there may be other members in this group who do not meet the drop criteria. My idea is that if you want to make modifications, it will take time. Since there are no problems, let's save some time, haha!

Copy link
Member

@neon-dev neon-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct that the accuracy must be checked when introducing such changes. I have checked and there are indeed some invalid npcs with group_drop="LEPHAR" in the LEPHARIST_BASTION_210020000 zone. So listing the npc IDs individually is the only correct solution here.

@neon-dev neon-dev changed the title Add missing drops for eltnen Add missing Golden Lepharist Insignia drops in Eltnen Feb 6, 2025
…les_map_eltnen.xml


Yes, adding '211031' is completely correct.

Co-authored-by: Neon <neon@beyond-aion.com>
@neon-dev neon-dev merged commit 4c91442 into beyond-aion:4.8 Feb 6, 2025
1 check passed
@sky1683589933 sky1683589933 deleted the Pull-Request_eltnen_drops branch February 11, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants