[FIX] owcorpusviewer: Avoid 'synchronous' evalJS, use 'runJavaScript' instead #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'wait' loop for QWebEngineView implemented in gui.WebView seems to interfere with key press delivery.
|
It works for me. 👍 |
|
Not yet. Highlighting does not work when using WebKit backend. |
ales-erjavec
changed the title
Fixes highlighting when using QWebKitWidgets
ales-erjavec
changed the title
|
Can you please test again. Re. travis: Yes. That is a different problem (Use Bag of Words widget with Term frequency: Binary) |
Codecov Report
@@ Coverage Diff @@
## master #341 +/- ##
=======================================
Coverage 84.92% 84.92%
=======================================
Files 33 33
Lines 1864 1864
Branches 336 336
=======================================
Hits 1583 1583
Misses 242 242
Partials 39 39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes gh-340 (probably)
Description of changes
Avoid 'synchronous'
evalJS, use asyncrunJavaScriptinstead.The 'wait' loop for QWebEngineView implemented in gui.WebView seems to
interfere with key press delivery.
This might be platform dependent (tested on macOS).
To duplicate create Corpus (bookexcerpts) -> Corpus Viewer and type e.g. hand really fast. Try multiple times. Notice if any keys are not entered. Switch to canvas and right click on an empty area to bring up the widget menu. The missing pressed keys are entered in the search box (that is the search line edit receives the dropped key events when shown).
Includes