Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test remove google-compute-engine #444

Merged

Conversation

PrimozGodec
Copy link
Collaborator

@PrimozGodec PrimozGodec commented Jul 2, 2019

Issue

google-compute-engine was added to the package to solve travis issues with boto library.

Description of changes

With this PR I am trying to remove google-compute-engine since it is preventing us to make conda-forege package OS independent. conda-forge/orange3-text-feedstock#26

Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec PrimozGodec force-pushed the remove-google-compute-engine branch 2 times, most recently from be128f4 to 365979d Compare July 2, 2019 12:07
@PrimozGodec
Copy link
Collaborator Author

Let's wait for #445 to be merged.

@PrimozGodec PrimozGodec force-pushed the remove-google-compute-engine branch from 365979d to f3e8b37 Compare July 2, 2019 12:28
@codecov-io
Copy link

codecov-io commented Jul 2, 2019

Codecov Report

Merging #444 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #444   +/-   ##
======================================
  Coverage    85.9%   85.9%           
======================================
  Files          34      34           
  Lines        1937    1937           
  Branches      331     331           
======================================
  Hits         1664    1664           
  Misses        233     233           
  Partials       40      40

@PrimozGodec PrimozGodec force-pushed the remove-google-compute-engine branch from f3e8b37 to 78b751a Compare July 2, 2019 12:41
@PrimozGodec PrimozGodec changed the title [NO-MERGE] Test remove google-compute-engine Test remove google-compute-engine Jul 2, 2019
@PrimozGodec PrimozGodec merged commit b575d26 into biolab:master Jul 2, 2019
@PrimozGodec PrimozGodec deleted the remove-google-compute-engine branch July 2, 2019 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants