semantic_search - fix callback to return proportions #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PrimozGodec
force-pushed
the
fix-semantic-search
branch
from
800772d to
19d5ae6
Compare
Codecov Report
@@ Coverage Diff @@
## master #747 +/- ##
==========================================
- Coverage 74.35% 74.34% -0.02%
==========================================
Files 73 73
Lines 9669 9669
Branches 1320 1321 +1
==========================================
- Hits 7189 7188 -1
Misses 2227 2227
- Partials 253 254 +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Semantic search implement a callback that gives bool (success) instead of proportion like it is made in other embedders.
Description of changes
Includes