Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Statistics - Fix layout (hidden + button on Windows) #984

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

PrimozGodec
Copy link
Collaborator

Issue

On Windows + button is hidden when the user opens the widget. Also, stretching is not optimal: empty space between the box and Apply button, and the whole box stretches instead of adding space at the bottom.

Description of changes

Update layout according to issue description.

Additionally, added missing __eq__ and __hash__ to ComputeValue.

Includes
  • Code changes
  • Tests
  • Documentation

@PrimozGodec
Copy link
Collaborator Author

@anjamejac, it solves the bug with hidden + button for me. Does it work in your case?

@codecov-commenter
Copy link

Codecov Report

Merging #984 (4b0b749) into master (5586779) will increase coverage by 0.07%.
The diff coverage is 95.23%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #984      +/-   ##
==========================================
+ Coverage   79.53%   79.60%   +0.07%     
==========================================
  Files          87       87              
  Lines       12332    12333       +1     
  Branches     1618     1618              
==========================================
+ Hits         9808     9818      +10     
+ Misses       2228     2220       -8     
+ Partials      296      295       -1     

@anjamejac
Copy link
Contributor

anjamejac commented Jun 12, 2023

Yes, @PrimozGodec, it also works in my case. Thank you :)

@janezd janezd self-assigned this Jun 16, 2023
@janezd janezd merged commit f9131fd into biolab:master Jun 16, 2023
@PrimozGodec PrimozGodec deleted the fix-statistics-view branch July 26, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants