Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qt: Add addressList field to SendCoinsRecipient for multiple addresses #857

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

VolodymyrBg
Copy link

This pull request adds a new field addressList to the SendCoinsRecipient class
to properly handle multiple addresses from unauthenticated payment requests.
Previously, the address field was being abused for this purpose, as noted
in a TODO comment.

The changes include:

  • Adding a new addressList field to SendCoinsRecipient
  • Updating the serialization methods to handle the new field
  • Modifying PaymentServer to populate the new field when multiple addresses
    are present
  • Updating ReceiveRequestDialog to display and copy the address list when
    available
  • Adding support for the "addresses" parameter in Bitcoin URI parsing
    This provides a cleaner solution for handling multiple addresses in payment
    requests without abusing the single address field.

@DrahtBot
Copy link
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.
A summary of reviews will appear here.

@DrahtBot
Copy link
Contributor

🚧 At least one of the CI tasks failed.
Debug: https://github.com/bitcoin-core/gui/runs/38586514593

Hints

Try to run the tests locally, according to the documentation. However, a CI failure may still
happen due to a number of reasons, for example:

  • Possibly due to a silent merge conflict (the changes in this pull request being
    incompatible with the current code in the target branch). If so, make sure to rebase on the latest
    commit of the target branch.

  • A sanitizer issue, which can only be found by compiling with the sanitizer and running the
    affected test.

  • An intermittent issue.

Leave a comment here, if you need help tracking down a confusing failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants