Add Portuguese wordlist to BIP39 #998
Conversation
|
The idea to create this wordlist began in bitcointalk.org forum. This is the thread where all details were discussed along its creation: We used python scripts to help us check for those rules:
|
|
See #720. |
That list has many problems: 1 - It is inactive for 2 years. 2- duplicated words: 3 - Problems with repeated word from spanish: 4 - Words that cannot be uniquely determined typing the first 4 characters. 5 - And Levenshtein distance < 1 Additionally, in the remaning words there are a lot of words which are negative and offensive, such as defunto. |
|
Just squashed all the 151 commits into a single one. Also added @brenorb as a co-author. |
Co-authored-by: Breno Rodrigues Brito <brenorb@gmail.com> Co-authored-by: ninjastic <ninjasticdev@protonmail.com> Co-authored-by: sabotag3x <sabotage.sta@gmail.com> Co-authored-by: bitmover <67111541+bitmover-studio@users.noreply.github.com> Co-authored-by: alegotardo <40860228+alegotardo@users.noreply.github.com> Co-authored-by: kuthullu <kuthullu@gmail.com> Co-authored-by: Trimegistus <trimegisto@rocketmail.com>
|
@slush0 @prusnak @voisine @ebfull So, I know that you may only care about the english list and that's why no new wordlist have been accepted in recent years. However, BIP-0039 was created to help users to restore their wallets as it's easier to write down 12 words than 64 random characters. (well, you know that better than me since you are the authors) I'll use your own words: "a group of easy to remember words" English words aren't easy to remember for non-english speakers. As well as portuguese words may not be easy for you, for example. In addition, a foreign language is more likely to cause typos and, at worst, make people lose their BTC. More than 250 million people speak portuguese, it's one of the most widely spoken languages in the world and it's the native language in Brazil, Portugal, Angola, Mozambique and other smaller countries. Moreover, few of them speak english. My point is that the BIP-0039 method should be easier for non-english speakers as well. PS: Let me know if you need more portuguese speakers to review the wordlist before accepting it. |
|
My comment may sound harsh for both the list creators and the maintainers of BIP0039 but nevertheless, I am still going to make it. Before the beginning of your work - have you asked any of BIP0039 maintainers whether there is a chance that your work will be merged in? Especially in the presence of many unmerged word lists proposals for other languages? By having a look at closed PRs one can see when exactly the last PR with a word list was merged in - it should be discouraging. However, the word lists creators seem to ignore this fact and then try to somehow push it through. A massive amount of time is wasted on all those hanging forever PRs. I would be really glad to see a clear direction set here. Anything would be better than the current situation. If the new word lists are meant to be never accepted then I would expect that the maintainers would clearly state the new word lists are not accepted. The ones already merged in would be the official BIP0039 word lists or this could be limited to just the English list. Does it solve the problem? No, because the word lists are for sure needed. I do not know how to proceed from this point (most likely new BIP, discussion on the mailing list etc.), but thanks to it people would not waste time! |
|
Why is this not merged yet? |
|
Hey, list will be merged? |
|
Sorry to say, but i am not sure at this point who or what exactly is the Bitcoin "community" when we have pull requests such as this, waiting to be merged for months. Some pull requests are even for years. This is the case to actually ask who is the "boss" of this project? Because community here does not seem to exist. |
|
@fortesp BIPs are a mechanism for publishing ideas/proposals. Accepting changes to those proposals is the BIP's authors responsibility. If they don't like a particular change, you're always welcome to publish your own competing proposal. |
|
I'm not sure we have a large community of Portuguese speaking people who also speak English and use Github. However, isn't it really one more strong argument in favor of having a Portuguese BIP039? |
|
@brenorb Agreement from the BIP authors is the only thing that matters. |
|
@sipa Agreed. But there is no feedback from any of the authors that i can see. Not sure what is missing or maybe not compliant, i did not check it myself to be honest. |
|
@sipa Ok, I'm one of the BIP authors and I'm pretty sure we all agree on it. What is the next step we need to do in practice? Is there a specific button to click? Can you show us the step-by-step process? |
You are not a BIP39 author. I am (one of them). Let's get this merged in. Edit: ACK |
|
@prusnak sorry, for the mistake. I'm one of the authors of this proposal. |
@prusnak Interpreting that as an ACK; let me know if I should revert |
Merge pull request bitcoin#998 from sabotag3x/master
The Portuguese wordlist was carefully checked manually by Portuguese and Brazilians in order to achieve a high level of quality. All the words are commonly used in both countries.
In addition the Portuguese wordlist was revised using Python in order to check the Levenshtein distance, words already used in other mnemonic sets and first 4 characters rules.
More details on the word selection process can be found in the Bitcointalk's Portuguese section.
Portuguese wordlist rules: