Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump toml_edit to 0.19 #32

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Bump toml_edit to 0.19 #32

merged 2 commits into from
Feb 22, 2023

Conversation

MarijnS95
Copy link
Contributor

No description provided.

@MarijnS95
Copy link
Contributor Author

https://docs.rs/crate/toml_edit/0.19.3/source/Cargo.toml looks like this implies an MSRV bump to 1.60 otherwise cargo shows really obscure errors...: https://github.com/bkchr/proc-macro-crate/actions/runs/4241597018/jobs/7372022311

@bkchr
Copy link
Owner

bkchr commented Feb 22, 2023

https://docs.rs/crate/toml_edit/0.19.3/source/Cargo.toml looks like this implies an MSRV bump to 1.60 otherwise cargo shows really obscure errors...: https://github.com/bkchr/proc-macro-crate/actions/runs/4241597018/jobs/7372022311

Ahh nice ty! I was already wondering last time where this weird issue was coming from!

@bkchr bkchr merged commit 5df7139 into bkchr:master Feb 22, 2023
@MarijnS95 MarijnS95 deleted the toml_edit-0.19 branch February 22, 2023 10:45
@MarijnS95
Copy link
Contributor Author

I ran into it with winit and objc as well: instead of cargo clearly complaining about an MSRV mismatch it first tries to resolve all the crate dependencies which apparently use a mechanism that isn't supported by an older Rust version.

@MarijnS95
Copy link
Contributor Author

@bkchr is anything else planned for a patch release or could we get this as a little version bump?

@bkchr
Copy link
Owner

bkchr commented Feb 22, 2023

Is that fixing an issue for you?

@MarijnS95
Copy link
Contributor Author

Not much beyond the usual duplicate dependencies because many crates update at a desynced pace... But as there are many more such issues there turns out to be less of a hurry.

@bkchr
Copy link
Owner

bkchr commented Feb 22, 2023

I will try to release it later today!

@bkchr
Copy link
Owner

bkchr commented Feb 27, 2023

@MarijnS95 sorry for the delay! https://github.com/bkchr/proc-macro-crate/releases/tag/v1.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants