Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terrible memory leak when importing a large git cloned repository #90

Closed
Norrox opened this issue Oct 22, 2024 · 6 comments · Fixed by #122
Closed

Terrible memory leak when importing a large git cloned repository #90

Norrox opened this issue Oct 22, 2024 · 6 comments · Fixed by #122

Comments

@Norrox
Copy link

Norrox commented Oct 22, 2024

Tested versions

System information

Issue description

See godotengine#97610

Anyone here have any ideas what can cause this,
I will do some investigation myself but have limited knowledge so any assistance is appreciated.

Steps to reproduce

Minimal reproduction project (MRP)
@Norrox
Copy link
Author

Norrox commented Oct 22, 2024

A thread on Reddit on the issue as well
https://www.reddit.com/r/godot/s/SLW8biIRor

@Starkium Starkium added the bug label Oct 24, 2024
@cryoboltinteractive
Copy link

Thank you for this, but the issue seems resolved in master branch of Godot Engine!

@Norrox
Copy link
Author

Norrox commented Oct 28, 2024 •
edited
Loading

Thank you for this, but the issue seems resolved in master branch of Godot Engine!

yeah i see now!
here it is, godotengine#98584
is this something we can cherry pick for 4.3? @jss2a98aj

@jss2a98aj
Copy link
Member

Yeah, that should be easy to cherry pick

@Starkium
Copy link

Starkium commented Nov 4, 2024

is this already merged in?

@jss2a98aj jss2a98aj mentioned this issue Nov 4, 2024
Merged
@jss2a98aj
Copy link
Member

is this already merged in?

Will be with #122

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[4.4 backport] Assorted import optimizations jss2a98aj/blazium
4 participants
@Starkium @jss2a98aj @Norrox @cryoboltinteractive