[VIDEO-2852] Facilitate running on GitHub's own runners #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
os.rmdir will error out if the directory doesn't exist. In a github action using msys2-ucrt, the line fails because the Scripts directory doesn't exist (meaning, it's likely the for loop that just ran didn't do anything either, BTW).
Upstream no longer provides Mercurial-style snapshots. However, we already host a port which follows that convention. I turned it into a patch following the well known convention, > git switch stable > git diff stable..164.3108-meson | git apply > git add * > git commit -m "Add Meson build" > git format-patch -n HEAD~1 And since x264 is another library that shares bugs w.r.t. Android 32-bit linking, I ported the relevant linker flags to the Android.mk for GStreamer so that downstream users can get it fixed out of the box. See #215 Fixes #286 Part-of: <https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1400>
Related MR: https://gitlab.freedesktop.org/gstreamer/gstreamer/-/merge_requests/8274 In 1.26 or >1.24.11 this patch will no longer be necessary.
|
@btgoodwin looks like this broke the default branch after merging so I undid the merge. I'm not sure why since this PR built. Can you re-submit it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes that, in concert with changes from laerdallabs/cerbero-action#1, allows for cerbero builds to run on the standard GHA
windows-2022-based runners. Summary:Scripts(vsbin) would exist when calling.rmdiron it, which was not the case for some reason. The result was a crash; the fix was to check if the directory exists before trying to delete it.mesonresolves that issue.gst-plugins-badperforms a now-necessary cast of a struct to ensure that the code can be compiled against SDKs newer than 10.0.22621.0 (26100 was the breaking version).