[VIDEO-2688] - Install Windows MSIs from custom source #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…verridden URI with uninstall clean up
lyramcmillan
changed the title
|
@lyramcmillan is this ready for review? looks like some unit tests are failing. |
Nope - trying to figure out why tests are failing. There's something bad in the test setup I think but it's proving intractable. Making into a draft. |
…on failure. Tryimg another version to see if it's something about 1.22.7
…ssues in the code
saraboule
reviewed
Mar 14, 2024
saraboule
reviewed
Mar 14, 2024
README.md
Outdated
| ### `devMsiUrl` | ||
|
|
||
| An optional override url for downloading the Windows gstreamer development libraries and tools MSI installer. If not specified, the default is `https://gstreamer.freedesktop.org/data/pkg/windows/<version>/gstreamer-1.0-devel-<arch>-<version>.msi`. | ||
| If the msiUrl is specified the devMsiUrl must also be specified. |
There was a problem hiding this comment.
techinically a run-on sentence. just add a comma there, or was that supposed to be then?
saraboule
reviewed
Mar 14, 2024
README.md
Outdated
|
|
||
| ### `msiUrl` | ||
|
|
||
| An optional override url for downloading the Windows gstreamer runtime MSI installer. If not specified, the default is `https://gstreamer.freedesktop.org/data/pkg/windows/<version>/gstreamer-1.0-<arch>-<version>.msi`. If this input is specified then the action post run will be run and gsrtreamer will be uninstalled. These are primarily meant to be used in self hosted runners and not run in the gstreamer hosted runners that are bootstrapped and executed as non-persistent containers. |
saraboule
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates supporting downloading Windows MSIs from an overridden URI with uninstall clean up. Added optional inputs and code to install MSIs from specified URLs using optional build run parameter for isolating the install location. Also has post build action cleanup uninstall of gstream,er
Ticket(s) Addressed:
Design Summary
Configuration changes:
Testing Notes and Procedure
Related Pull Requests