Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Generic endpoint to get logs from Admin Service #4844

Merged
merged 2 commits into from
Mar 12, 2025
Merged

feat: Generic endpoint to get logs from Admin Service #4844

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a24891
chore: convert admin log endpoint to a generic endpoint
jvmakine Mar 12, 2025
606f6b5
chore(autofmt): Automated formatting
github-actions[bot] Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore(autofmt): Automated formatting
@github-actions
github-actions[bot] committed Mar 12, 2025
commit 606f6b57bc35d309ee6c62b5a5e0a5540565c4b4
2 changes: 1 addition & 1 deletion frontend/console/src/features/timeline/hooks/use-timeline.ts
View file
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@ export const useTimeline = (isStreaming: boolean, filters: TimelineQuery_Filter[
const fetchTimeline = async ({ signal }: { signal: AbortSignal }) => {
try {
console.debug('fetching timeline')
const response = await client.getTimeline({query: { filters, limit, order }}, { signal })
const response = await client.getTimeline({ query: { filters, limit, order } }, { signal })
return response.events
} catch (error) {
if (error instanceof ConnectError) {
2 changes: 1 addition & 1 deletion internal/buildengine/deploy.go
View file
Original file line number Diff line number Diff line change
@@ -415,7 +415,7 @@ func (c *DeployCoordinator) runChangeLogger(ctx context.Context, key key.Changes
Query: &timelinepb.TimelineQuery{
Limit: 100,
Filters: []*timelinepb.TimelineQuery_Filter{
&timelinepb.TimelineQuery_Filter{
{
Filter: &timelinepb.TimelineQuery_Filter_Changesets{
Changesets: &timelinepb.TimelineQuery_ChangesetFilter{
Changesets: []string{key.String()},
Loading