Ensure topological sort before deletion #2169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To increase the likelihood of preserving connected paths, it is always preferable to delete upstream nodes first before deleting merge nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The semantics of the node deletion action allow preserving connected paths whenever possible. Still, when a node receives multiple input arguments, it becomes ambiguous to decide which path should be continued.
However, this problem becomes again decidable if we also delete all the multiple input arguments in the same operation. To leverage this, we need to ensure the set of deleted nodes is topologically sorted, such that we delete all upstream nodes before downstream merge nodes.
Fixes #1523