hashindex_compact: fix eval order (check idx before use), fixes #5899

[ThomasWaldmann]

also: fix "off by one" comment

thanks to https://github.com/tomaszduda23 for debugging and finding this.

[codecov-commenter]

Codecov Report

Merging #6816 (3f517b0) into 1.2-maint (0cac871) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           1.2-maint    #6816      +/-   ##
=============================================
- Coverage      82.86%   82.85%   -0.01%     
=============================================
  Files             38       38              
  Lines          10515    10515              
  Branches        2195     2195              
=============================================
- Hits            8713     8712       -1     
  Misses          1287     1287              
- Partials         515      516       +1     

Impacted Files	Coverage Δ
src/borg/platform/__init__.py	72.00% <0.00%> (-12.00%)	⬇️
src/borg/fuse_impl.py	65.38% <0.00%> (-11.54%)	⬇️
src/borg/platform/base.py	76.69% <0.00%> (-3.01%)	⬇️
src/borg/helpers/misc.py	77.09% <0.00%> (-1.68%)	⬇️
src/borg/xattr.py	50.00% <0.00%> (-1.20%)	⬇️
src/borg/helpers/fs.py	78.82% <0.00%> (-1.18%)	⬇️
src/borg/repository.py	83.54% <0.00%> (-0.19%)	⬇️
src/borg/archiver.py	80.61% <0.00%> (+0.42%)	⬆️
src/borg/archive.py	82.11% <0.00%> (+0.49%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cac871...3f517b0. Read the comment docs.

[KN4CK3R]

Do you still want the ports? 😏

[ThomasWaldmann]

@KN4CK3R they are already done, see closed PRs.

[KN4CK3R]

Ah, I was waiting for this PR to get closed. 👍

[ThomasWaldmann]

Well, "merged" means "done". "Closed" (for a PR) would mean "rejected with unmerged changes".