Feat/assign unassign tags #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlin95
requested review from
HaGuesto,
fhenrich33 and
pylipp
and removed request for
HaGuesto
HaGuesto
approved these changes
Feb 24, 2025
There was a problem hiding this comment.
code review passed
even though I would like to see some test but would move this on playwright for now.
functional review
The color of the tags is not being applied in the form
In BoxEdit it works, I checked the form field and we created a form component here where you can copy the styling options for the select field:
Please fix the styling. Otherwise, I do not have to review it again.
|
@HaGuesto fixed the styling |
pylipp
approved these changes
Feb 27, 2025
|
thanks @jlin95 , the tag badges are colored now. I added a commit to make the AssignTagsButton stretch across the full width of the menu, before there was a gap on the right side. |
|
Actual ticket is https://trello.com/c/6mD1HYg7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the assign tags functionality. Unassign tags functionality will be done in a separate PR.