Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only take certain box states into account in check of still being assigned to product #2022

Merged
merged 4 commits into from
Mar 11, 2025
Merged

Only take certain box states into account in check of still being assigned to product #2022

merged 4 commits into from
Mar 11, 2025

Conversation

pylipp
Copy link
Contributor

@pylipp pylipp commented Mar 10, 2025 •
edited
Loading

@pylipp pylipp force-pushed the fix-disable-assort-product-with-assigned-boxes branch from dd684bf to 0473f99 Compare March 10, 2025 16:05
@codecov Codecov
Copy link

codecov bot commented Mar 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.75%. Comparing base (fea4660) to head (943ef1c).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #2022   +/-   ##
=======================================
  Coverage   82.75%   82.75%           
=======================================
  Files         257      257           
  Lines       16174    16175    +1     
  Branches     2490     2490           
=======================================
+ Hits        13384    13385    +1     
  Misses       2759     2759           
  Partials       31       31
Flag Coverage Δ
backend 99.66% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pylipp pylipp force-pushed the fix-disable-assort-product-with-assigned-boxes branch 2 times, most recently from 943ef1c to f248e87 Compare March 11, 2025 08:25
@pylipp pylipp marked this pull request as ready for review March 11, 2025 08:35
@pylipp pylipp merged commit f059c17 into master Mar 11, 2025
12 of 13 checks passed
@pylipp pylipp deleted the fix-disable-assort-product-with-assigned-boxes branch March 11, 2025 08:47
HaGuesto
HaGuesto reviewed Mar 11, 2025
View reviewed changes
Copy link
Member

@HaGuesto HaGuesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review passed @pylipp

I assume you create a follow-up ticket to split this up between inStockItems and inTransit Items, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaGuesto HaGuesto HaGuesto left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pylipp @HaGuesto