Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle god user without any base_ids in their auth token #2024

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

pylipp
Copy link
Contributor

@pylipp pylipp commented Mar 11, 2025

@pylipp pylipp requested a review from HaGuesto March 11, 2025 08:31
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.74%. Comparing base (28fadd9) to head (24634ef).
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2024   +/-   ##
=======================================
  Coverage   82.74%   82.74%           
=======================================
  Files         257      257           
  Lines       16169    16169           
  Branches     2490     2490           
=======================================
  Hits        13379    13379           
  Misses       2759     2759           
  Partials       31       31           
Flag Coverage Δ
backend 99.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@HaGuesto HaGuesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, makes sense. I handled god users further down similarly.

code review passed

@pylipp pylipp merged commit db294dc into master Mar 11, 2025
10 of 11 checks passed
@pylipp pylipp deleted the fix-god-user-without-base-ids-in-jwt branch March 11, 2025 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants