Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Site hack for Twitter doesn't work #1240

Closed
srirambv opened this issue Sep 21, 2018 · 3 comments
Closed

Site hack for Twitter doesn't work #1240

srirambv opened this issue Sep 21, 2018 · 3 comments
Labels
priority/P2 A bad problem. We might uplift this to the next planned release. site-bug

Comments

@srirambv
Copy link
Contributor

Description

Site hack for Twitter doesn't work. Found while verifying #84

Steps to Reproduce

  1. Visit https://twitter.com/ in a new tab
  2. Enable Block script from Shields
  3. Shows JS blocked want to navigate to legacy site. Click yes does nothing.

Actual result:

image

Expected result:

Should load Twitter site even when script is blocked similar to muon

Reproduces how often:

Easy

Brave version (chrome://version info)

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux

Reproducible on current release:

No. Block script loads the site correctly on b-l

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@bbondy
Copy link
Member

bbondy commented Sep 24, 2018

Moving to 1.x

@bbondy bbondy modified the milestones: Releasable builds 0.55.x, 1.x Backlog Sep 24, 2018
@btlechowski
Copy link

Reproduced on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Sep 28, 2018
@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
@bsclifton
Copy link
Member

Verified this works as expected now 🎉

@bbondy bbondy added this to the Closed / Invalid milestone Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/P2 A bad problem. We might uplift this to the next planned release. site-bug
Projects
None yet
Development

No branches or pull requests

5 participants