Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add site-hacks from browser-laptop #84

Closed
9 of 12 tasks
bbondy opened this issue Mar 1, 2018 · 2 comments
Closed
9 of 12 tasks

Add site-hacks from browser-laptop #84

bbondy opened this issue Mar 1, 2018 · 2 comments
Assignees
@bbondy
Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@bbondy
Copy link
Member

bbondy commented Mar 1, 2018 •
edited
Loading

Site hacks are to fix things like blocking banner ads, or to work around site restrictions.
https://github.com/brave/browser-laptop/blob/master/js/data/siteHacks.js

Implements some of the needed site-hacks for browser-laptop.

  • Empty data URL redirect for sp1.nypost.com
  • Empty data URL redirect for sp.nasdaq.com
  • Google tag services stub
  • Google tag manager stub
  • Block https://www.lesechos.fr/xtcore.js
  • Block https://*.y8.com/js/sdkloader/outstream.js
  • Forbes custom cookie
  • Twitter NoScript redirect
  • Brave UA whitelist

TODO:

  • Cookie exceptions
  • Referrer exceptions
  • Local storage exceptions
@bbondy bbondy self-assigned this Mar 1, 2018
@bbondy bbondy changed the title Create site-hacks-extension Add site-hacks from browse-rlaptop Mar 26, 2018
@bbondy bbondy changed the title Add site-hacks from browse-rlaptop Add site-hacks from browser-laptop Mar 26, 2018
@bbondy bbondy mentioned this issue Mar 26, 2018
Merged
6 tasks
@bbondy bbondy added this to the Milestone 2: To offer Installable and updatable builds milestone Apr 3, 2018
bbondy added a commit to brave/brave-core that referenced this issue Apr 4, 2018
@bbondy
Use Brave UA for whitelist of URL patterns
ceaa968 
Implements a sub-task for brave/brave-browser#84
@bbondy bbondy mentioned this issue Apr 4, 2018
Merged
9 tasks
@bbondy
Copy link
Member Author

bbondy commented Apr 4, 2018

Referrer, local storage, and cookie blocking site hacks will be implemented as part of:
#145

So closing this issue.

@bbondy bbondy closed this as completed Apr 4, 2018
cezaraugusto pushed a commit that referenced this issue May 15, 2018
@bbondy
Customize forbes.com cookies
bfeaa65 
Fixes a sub-item in "Add site-hacks from browser-laptop #84"

See https://github.com/brave/browser-laptop/blob/master/js/data/siteHacks.js#L60 for the equivalent rule
cezaraugusto pushed a commit that referenced this issue May 15, 2018
@bbondy
Don't allow Twitter to redirect to mobile site
25ea658 
Fixes a sub-item in "Add site-hacks from browser-laptop #84"

Twitter tries to do this for some reason when scripts are blocked with
NoScript.
cezaraugusto pushed a commit that referenced this issue May 15, 2018
@bbondy
Merge pull request #84 from brave/brave-ua-whitelist
a7f7dda 
Use Brave UA for whitelist of URL patterns
@bbondy bbondy modified the milestones: Milestone 2: To offer Installable and updatable builds, Releasable builds Jun 13, 2018
@bbondy bbondy added the QA/Yes label Aug 18, 2018
@srirambv srirambv mentioned this issue Sep 21, 2018
Closed
@srirambv
Copy link
Contributor

srirambv commented Sep 21, 2018 •
edited by LaurenWags
Loading

Verification Passed on

Brave 0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Linux
  • Verified data URL redirect for sp1.nypost.com and sp.nasdaq.com
  • Verified Brave UA for DDG/Adobe/Netflix and Brave.com
  • Verified Signing into Google Hangouts worked even with FP blocking it
  • Verified /xtscore.js is blocked on https://lesechos.fr
  • Verified Forbes custom cookie is set and no cookie modal is shown
  • Twitter site hack doesn't work (Issue Site hack for Twitter doesn't work #1240 logged)

Verification passes on

Brave 0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision 16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS Windows 7

Verified passed with

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X

@btlechowski btlechowski mentioned this issue Sep 26, 2018
Closed
@LaurenWags LaurenWags mentioned this issue Oct 3, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

No branches or pull requests
4 participants
@bbondy @srirambv @LaurenWags @btlechowski