Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbes custom cookie not being set - follow up to 84 #1407

Open
LaurenWags opened this issue Oct 3, 2018 · 2 comments
Open

Forbes custom cookie not being set - follow up to 84 #1407

LaurenWags opened this issue Oct 3, 2018 · 2 comments
Labels
browser-laptop-parity needs-investigation A bug not 100% confirmed/fixed priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes

Comments

@LaurenWags
Copy link
Member

Description

Forbes custom cookie is not working on Beta or Dev versions. Found while testing #84

Steps to Reproduce

  1. Clean profile
  2. Navigate to forbes.com
  3. Open Dev Tools > Network tab
  4. Reload forbes.com
  5. Click on first element (forbes.com)

Actual result:

only client_id is displayed, no other info for cookie.
Beta 0.55.10:
screen shot 2018-10-03 at 10 42 10 am

Dev 0.56.1:
screen shot 2018-10-03 at 10 40 50 am

Expected result:

cookie should show as it does on b-l (this is a screenshot from 0.24.0 on b-l)
screen shot 2018-10-03 at 10 41 21 am

Reproduces how often:

easily

Brave version (chrome://version info)

Brave 0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X
Brave 0.56.1 Chromium: 70.0.3538.22 (Official Build) dev (64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? yes
  • Does it reproduce on browser-laptop? no

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? no
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

Reproduced by @srirambv
cc @kjozwiak @btlechowski @GeetaSarvadnya

@LaurenWags LaurenWags added this to the 1.x Backlog milestone Oct 3, 2018
@btlechowski
Copy link

Reproduced on Win7 x64 v0.55.10.

It seems that the cookie is only set when forbes.com page is opened for the first time.
image

Subsequent page loads will not add the custom cookie.

@srirambv
Copy link
Contributor

srirambv commented Oct 3, 2018

Seeing it on home page after a while even when the cookie consent page is not shown.
image

@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. priority/P3 The next thing for us to work on. It'll ride the trains. needs-investigation A bug not 100% confirmed/fixed and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Oct 5, 2018
@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser-laptop-parity needs-investigation A bug not 100% confirmed/fixed priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes
Projects
None yet
Development

No branches or pull requests

4 participants