-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enabling Rewards from panel should have waiter message when opting in #1502
Labels
browser-laptop-parity
design
A design change, especially one which needs input from the design team
feature/rewards
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/include
Milestone
Comments
Reproduced on Linux as well |
This was referenced Oct 23, 2018
18 tasks
NejcZdovc
added a commit
to brave/brave-core
that referenced
this issue
Oct 24, 2018
The referenced issue #1838 is still reproducible on Dev Build version 0.57.3. This issue is not there on Release build 0.55.20. |
#1838 was not included in 0.57.3 |
Verified passed with
Verification Passed on
Verification Passed on
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
browser-laptop-parity
design
A design change, especially one which needs input from the design team
feature/rewards
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/include
Description
Similar to issue reported in #1099. If you are using a fresh profile and you click on the BAT logo and are prompted to join Brave Rewards, when you click 'Join Rewards' there is a lag. It would be helpful if this had a similar waiter message as when opting in from
chrome://rewards
. I'm not sure if the exact same one is appropriate, users might not know what 'creating wallet' means here.Steps to Reproduce
Actual result:
Note lag, doesn't seem like anything is happening.
Expected result:
Waiter message similar to when opting in from
chrome://rewards
pageReproduces how often:
easily
Brave version (chrome://version info)
Reproducible on current release:
Website problems only:
Additional Information
cc @NejcZdovc @jenn-rhim
The text was updated successfully, but these errors were encountered: