Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BAT icon missing in Brave News display ads #20011

Closed
mattmcalister opened this issue Dec 9, 2021 · 2 comments · Fixed by brave/brave-core#11656
Closed

BAT icon missing in Brave News display ads #20011

mattmcalister opened this issue Dec 9, 2021 · 2 comments · Fixed by brave/brave-core#11656
Assignees
@alexsafe
Labels
feature/brave-news formerly brave-today OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/exclude
Milestone
1.35.x - Release

Comments

@mattmcalister
Copy link

Description

The BAT Ad icon needs to appear in the upper right hand corner of Brave News Display Ads
image
@mattmcalister mattmcalister added OS/Android Fixes related to Android browser functionality feature/brave-news formerly brave-today labels Dec 9, 2021
@alexsafe alexsafe added this to the 1.35.x - Nightly milestone Dec 21, 2021
@alexsafe alexsafe mentioned this issue Dec 21, 2021
Merged
25 tasks
@stephendonner
Copy link

Verified PASSED using Brave 1.35.74, Chromium 97.0.4692.71 on a Google Pixel XL running Android 9.0.

Steps:

  1. installed 1.35.74
  2. opened brave://flags
  3. enabled Brave News
  4. tapped on Relaunch
  5. opened a new-tab page
  6. tapped on Show Brave News
  7. swiped down, viewed cards

Confirmed using both light and dark themes, that the BAT ad icon was legible and in the correct place.

example example example example example
Screenshot_20220105-133137 Screenshot_20220105-153536 Screenshot_20220105-164139 Screenshot_20220105-164203 Screenshot_20220105-164228

@srirambv srirambv mentioned this issue Jan 10, 2022
Closed
@srirambv
Copy link
Contributor

Verification failed on Samsung Tab A with Android 10 running 1.35.77 x64 Beta build. Logged #20412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexsafe alexsafe

Labels
feature/brave-news formerly brave-today OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.35.x - Release
Development

Successfully merging a pull request may close this issue.

[Android] Brave news - fixes settings bar position, cards and display ads tweaks brave/brave-core
4 participants
@mattmcalister @stephendonner @alexsafe @srirambv