Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Ads not shown on News feed #20412

Closed
srirambv opened this issue Jan 10, 2022 · 6 comments
Closed

Brave Ads not shown on News feed #20412

srirambv opened this issue Jan 10, 2022 · 6 comments
Assignees
Labels
closed/duplicate Issue has already been reported OS/Android Fixes related to Android browser functionality

Comments

@srirambv
Copy link
Contributor

Description

Found while testing #20011, Brave Ads not shown on News feed

Steps to reproduce

  1. Enable Brave News via flag
  2. Opt-in to Brave News
  3. No ads are shown

Actual result

Brave Ads not shown on News feed


2022-01-10 01:58:18.073 2527-2527/? V/chromium: [VERBOSE1:bundle.cc(128)] Creative set id 461d9877-85e0-40fd-8685-964898762cac does not support android
2022-01-10 01:58:18.073 2527-2527/? V/chromium: [VERBOSE1:bundle.cc(428)] creative set id 461d9877-85e0-40fd-8685-964898762cac has no entries
2022-01-10 01:58:18.073 2527-2527/? V/chromium: [VERBOSE1:bundle.cc(128)] Creative set id 2f05daed-4062-4be9-b4a8-a5459ea72f11 does not support android
2022-01-10 01:58:18.073 2527-2527/? V/chromium: [VERBOSE1:bundle.cc(428)] creative set id 2f05daed-4062-4be9-b4a8-a5459ea72f11 has no entries
2022-01-10 01:58:18.075 2527-2527/? V/chromium: [VERBOSE1:bundle.cc(128)] Creative set id 4e2fe7f1-d9a7-4b7d-988f-ab3e0bcabec3 does not support android
2022-01-10 01:58:18.075 2527-2527/? V/chromium: [VERBOSE1:bundle.cc(428)] creative set id 4e2fe7f1-d9a7-4b7d-988f-ab3e0bcabec3 has no entries
2022-01-10 01:58:18.076 2527-2527/? V/chromium: [VERBOSE1:bundle.cc(128)] Creative set id 05fa6b16-f12a-44ee-9914-1e8ab99aab93 does not support android
2022-01-10 01:58:18.076 2527-2527/? V/chromium: [VERBOSE1:bundle.cc(128)] Creative set id 05fa6b16-f12a-44ee-9914-1e8ab99aab93 does not support android
2022-01-10 01:58:18.076 2527-2527/? V/chromium: [VERBOSE1:bundle.cc(428)] creative set id 05fa6b16-f12a-44ee-9914-1e8ab99aab93 has no entries
2022-01-10 01:58:18.077 2527-2527/? V/chromium: [VERBOSE1:bundle.cc(128)] Creative set id 0e2869a9-b40f-455d-a599-76c2e6bc332e does not support android
2022-01-10 01:58:18.077 2527-2527/? V/chromium: [VERBOSE1:bundle.cc(428)] creative set id 0e2869a9-b40f-455d-a599-76c2e6bc332e has no entries
2022-01-10 01:58:18.117 2527-2527/? V/chromium: [VERBOSE3:bundle.cc(634)] Successfully saved creative promoted content ads state
2022-01-10 01:58:18.117 2527-2527/? V/chromium: [VERBOSE2:epsilon_greedy_bandit_resource.cc(50)] Successfully loaded epsilon greedy bandit segments:
2022-01-10 01:58:18.118 2527-2527/? V/chromium: [VERBOSE2:epsilon_greedy_bandit_resource.cc(52)]   untargeted
2022-01-10 01:58:18.118 2527-2527/? V/chromium: [VERBOSE2:epsilon_greedy_bandit_resource.cc(52)]   Technology & Computing
2022-01-10 01:58:18.118 2527-2527/? V/chromium: [VERBOSE2:epsilon_greedy_bandit_resource.cc(52)]   Real Estate
2022-01-10 01:58:18.118 2527-2527/? V/chromium: [VERBOSE2:epsilon_greedy_bandit_resource.cc(52)]   Personal Finance
2022-01-10 01:58:18.119 2527-2527/? V/chromium: [VERBOSE2:epsilon_greedy_bandit_resource.cc(52)]   Business
2022-01-10 01:58:18.119 2527-2527/? V/chromium: [VERBOSE2:epsilon_greedy_bandit_resource.cc(52)]   Crypto Curious
2022-01-10 01:58:18.119 2527-2527/? V/chromium: [VERBOSE2:epsilon_greedy_bandit_resource.cc(52)]   Consumer Crypto
2022-01-10 01:58:18.119 2527-2527/? V/chromium: [VERBOSE2:epsilon_greedy_bandit_resource.cc(52)]   crypto
2022-01-10 01:58:18.119 2527-2527/? V/chromium: [VERBOSE2:epsilon_greedy_bandit_resource.cc(52)]   Crypto Purchase Intent
2022-01-10 01:58:18.119 2527-2527/? V/chromium: [VERBOSE2:epsilon_greedy_bandit_resource.cc(52)]   Arts & Entertainment
2022-01-10 01:58:18.120 2527-2527/? V/chromium: [VERBOSE2:epsilon_greedy_bandit_resource.cc(52)]   Hobbies & Interests
2022-01-10 01:58:18.120 2527-2527/? V/chromium: [VERBOSE2:epsilon_greedy_bandit_resource.cc(52)]   Intel B2B
2022-01-10 01:58:18.122 2527-2527/? V/chromium: [VERBOSE1:ad_server.cc(158)] Fetch catalog in 2 hours, 16 minutes, 56 seconds at 2:45 PM
2022-01-10 01:58:18.122 2527-2527/? V/chromium: [VERBOSE3:bundle.cc(470)] Successfully deleted creative ad notifications state
2022-01-10 01:58:18.123 2527-2527/? V/chromium: [VERBOSE3:bundle.cc(482)] Successfully deleted creative inline content ads state
2022-01-10 01:58:18.123 2527-2527/? V/chromium: [VERBOSE3:bundle.cc(494)] Successfully deleted creative new tab page ads state
2022-01-10 01:58:18.124 2527-2527/? V/chromium: [VERBOSE3:bundle.cc(506)] Successfully deleted creative new tab page ad wallpapers state
2022-01-10 01:58:18.133 2527-2527/? V/chromium: [VERBOSE3:bundle.cc(518)] Successfully deleted creative promoted content ads state
2022-01-10 01:58:18.140 2527-2527/? V/chromium: [VERBOSE3:bundle.cc(530)] Successfully deleted campaigns state
2022-01-10 01:58:18.149 2527-2527/? V/chromium: [VERBOSE3:bundle.cc(542)] Successfully deleted segments state
2022-01-10 01:58:18.157 2527-2527/? V/chromium: [VERBOSE3:bundle.cc(554)] Successfully deleted creative ads state
2022-01-10 01:58:18.165 2527-2527/? V/chromium: [VERBOSE3:bundle.cc(566)] Successfully deleted dayparts state
2022-01-10 01:58:18.173 2527-2527/? V/chromium: [VERBOSE3:bundle.cc(578)] Successfully deleted geo targets state
2022-01-10 01:58:18.246 2527-2527/? V/chromium: [VERBOSE3:bundle.cc(592)] Successfully saved creative ad notifications state
2022-01-10 01:58:18.258 2527-2527/? V/chromium: [VERBOSE3:bundle.cc(606)] Successfully saved creative inline content ads state
2022-01-10 01:58:18.273 2527-2527/? V/chromium: [VERBOSE3:bundle.cc(620)] Successfully saved creative new tab page ads state
2022-01-10 01:58:18.274 2527-2527/? V/chromium: [VERBOSE3:bundle.cc(646)] Successfully purged expired conversions
2022-01-10 01:58:18.282 2527-2527/? V/chromium: [VERBOSE3:bundle.cc(658)] Successfully saved conversions state
2022-01-10 01:58:21.621 2527-2527/? V/chromium: [VERBOSE1:text_classification_model.cc(90)] No text classification probabilities found for en-US locale
2022-01-10 01:58:21.621 2527-2527/? V/chromium: [VERBOSE1:eligible_inline_content_ads_v1.cc(40)] Get eligible inline content ads:
2022-01-10 01:58:21.630 2527-2527/? V/chromium: [VERBOSE1:eligible_inline_content_ads_v1.cc(150)] Get eligible ads for untargeted segment
2022-01-10 01:58:21.636 2527-2527/? V/chromium: [VERBOSE1:eligible_inline_content_ads_v1.cc(161)] No eligible ads for untargeted segment
2022-01-10 01:58:21.636 2527-2527/? V/chromium: [VERBOSE1:inline_content_ad_serving.cc(81)] Inline content ad not served: No eligible ads found
2022-01-10 01:58:25.277 2527-2527/? V/chromium: [VERBOSE1:rewards_service_impl.cc(466)] Starting ledger process

Expected result

Should show ads similar to desktop

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version?Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: All

Brave version

1.35.77 x64 Beta & 1.36.23 x64 Nightly build

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @alexsafe @mattmcalister @tmancey @brave/legacy_qa
Note: issue happens with or without rewards being enabled.

@tmancey
Copy link
Contributor

tmancey commented Jan 10, 2022

@srirambv can you please download the catalog on the device experiencing this issue to confirm there are inline content ads in the catalog for Android please. Thanks

@anthonypkeane anthonypkeane added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 26, 2022
@anthonypkeane
Copy link

@srirambv to recheck on Nightly

@srirambv
Copy link
Contributor Author

@tmancey I am getting v9 catalog and there are 2 inline content available for all platforms

[{"type":{"code":"inline_content_all_v1","name":"inline_content","version":1,"platform":"all"},"payload":{"title":"Exchange between 175+ market pairs and earn up to 0.5% in instant cashback","ctaText":"Exchange Now!","imageUrl":"https://pcdn.brave.com/brave-news-ads/a1c5d5cb-c5aa-4db0-b9cc-09ee0dee78d4.jpg.pad","targetUrl":"https://nexo.io/exchange?utm_source=brave&utm_medium=fixed&utm_campaign=brave_news_exchange_cashback_jan22","dimensions":"900x750","description":"Nexo"},"creativeInstanceId":"8bad2272-1739-48dc-9f92-a2787a19d56b"},{"type":{"code":"inline_content_all_v1","name":"inline_content","version":1,"platform":"all"},"payload":{"title":"Invest in crypto instantly and securely. Get up to 0.5% cashback on your purchase.","ctaText":"Buy Now!","imageUrl":"https://pcdn.brave.com/brave-news-ads/920f84d4-d34c-430a-af1e-3fa68b31eec0.jpg.pad","targetUrl":"https://nexo.io/buy-crypto?utm_source=brave&utm_medium=fixed&utm_campaign=brave_news_buy_cashback_jan22","dimensions":"900x750","description":"Nexo"},"creativeInstanceId":"a0ef351a-e17b-44b1-bd0e-19ed48a2dee9"}],"conversions":[],"creativeSetId":"fc3bf5df-df86-4faa-8dc8-7fba9b257e8e","splitTestGroup":""}]},{"ptr":1,"endAt":"2022-02-01T16:59:00.000Z","startAt":"2021-12-30T11:00:00.000Z","dailyCap":1,"dayParts":[],"priority":1,"campaignId":"8aebb104-493c-48a2-bb7a-e03b679af0fb","geoTargets":[{"code":"IN","name":"India"}],"advertiserId":"8721e747-3604-4df7-bbb7-a14704f6b8c1","creativeSets":[{"oses":[{"code":"_Bt5nxrNo","name":"macos"},{"code":"mbwfZU-4W","name":"android"},{"code":"-Ug5OXisJ","name":"linux"},{"code":"k80syyzDa","name":"ios"},{"code":"i1g4cO6Pl","name":"windows"}],"value":"0.005","perDay":10,"perWeek":0,"channels":[],"perMonth":0,"segments":

@tmancey
Copy link
Contributor

tmancey commented Jan 27, 2022

@anthonypkeane @srirambv #20658 should resolve this issue. We will test once the fix is in place. Thanks

@tmancey
Copy link
Contributor

tmancey commented Jan 27, 2022

Can we please close this as a duplicate of #20658

@srirambv
Copy link
Contributor Author

Can we please close this as a duplicate of #20658

Works for me. Closing as dupe.

@srirambv srirambv added closed/duplicate Issue has already been reported and removed bug priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude feature/ads feature/brave-news formerly brave-today labels Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported OS/Android Fixes related to Android browser functionality
Projects
None yet
Development

No branches or pull requests

3 participants