-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline-content ads are empty #20658
Comments
Feels like this might just be an issue with something in production, server-side?
|
Caused by:
|
This seems like 2 separate issues
I had to refresh a few times to get the crash but when I did get the crash I received the "start async" line but not the "end async" line:
|
Some more info after 500 refreshes 😊 Maybe it's caused when the ads service restarts whilst already in the middle of a call to get an inline content ad
This is on a profile which has some rewards "issues"
|
This issue only affected nightly and v2 ad serving pipeline which is configured for nightly via griffin |
Verified
Followed my original steps to reproduce, and confirmed inline-content ads display and work (links, ads redemption).
Verified
Followed my original steps to reproduce, and confirmed inline-content ads display and work (links, ads redemption): |
@stephendonner I would recommend we instead remove the v2 study for beta from griffin. I will raise a PR. @kjozwiak your thoughts? I would rather not uplift any changes for v2 to release or beta until tested in nightly. |
@stephendonner @kjozwiak griffin PR at brave/brave-variations#214 |
Study removal sounds good; just FYI this has been verified on both Android and macOS, |
Verification passed on
Ad serving v1
Ad serving v2
|
Description
Inline-content ads are empty
Steps to reproduce
1.36.63
Show Brave News
Actual result
They are empty, without content.
mobizen_20220124_122512.mp4
Expected result
Should have a heading/title, source attribution, and of course the larger content image.
Issue reproduces how often
100%
Device details
arm64
Google Pixel XL
phone9.0
Brave version
1.36.63, Chromium 97.0.5692.99
cc @alexsafe @srirambv @btlechowski @mattmcalister
The text was updated successfully, but these errors were encountered: