Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

using CHROMN as attribution when searching using Bing #20659

Closed
kjozwiak opened this issue Jan 24, 2022 · 3 comments · Fixed by brave/brave-core#11994
Closed

using CHROMN as attribution when searching using Bing #20659

kjozwiak opened this issue Jan 24, 2022 · 3 comments · Fixed by brave/brave-core#11994

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Jan 24, 2022

Description

When searching via Brave within Desktop/Android, we use CHROMN as the search attribution. I'm pretty sure this belongs to Google which means any Brave user searching with Bing is generating revenue for Google.

https://www.bing.com/search?q=test&PC=U316&FORM=CHROMN

Steps to Reproduce

  1. launch Brave
  2. Using Bing, perform a search and you'll notice PC=U316&FORM=CHROMN being used as the search attribution

Actual result:

Using the following search attribution when using Bing:

https://www.bing.com/search?q=test&PC=U316&FORM=CHROMN

Expected result:

Remove PC=U316&FORM=CHROMN

Url should be: https://www.bing.com/search?q=%s

Reproduces how often:

100% reproducible using the STR/Cases mentioned above.

Desktop Brave version:

Brave | 1.34.81 Chromium: 97.0.4692.99 (Official Build) (64-bit)
-- | --
Revision | d740da257583289dbebd2eb37e8668928fac5ead-refs/branch-heads/4692@{#1461}
OS | Windows 11 Version 21H2 (Build 22000.438)

Android Device details:

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Mobile/Phone
  • Android version: Android 12

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

CCing @bsclifton @janypiotrowski @rebron

@kjozwiak kjozwiak added bug feature/search QA/Yes OS/Android Fixes related to Android browser functionality OS/Desktop labels Jan 24, 2022
@kjozwiak
Copy link
Member Author

iOS has a similar issue as per brave/brave-ios#4890 but uses MOZMBA rather than CHROMN.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 7, 2022

Verification PASSED on

Brave | 1.36.86 Chromium: 98.0.4758.87 (Official Build) beta (64-bit)
-- | --
Revision | e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS | Windows 10 Version 21H2 (Build 19044.1503)

Case 1: Search using bing search keyword :b
- Clean profile 1.36.x
- Enter the Bing search keyword :b in the URL bar and hit TAB
- Enter any string and confirmed URL no longer has the attached search-attribution parameters mentioned in the issue #20659 (comment)
- Opened dev tool and confirmed URL no longer has the attached search-attribution parameters

Search result parameter Dev tool parameter
image image

Case 2: Search using bing search engine via brave://settings/search
- Clean profile 1.36.x
- Select Bing as default search engine from brave://settings/search
- Enter any string and confirmed URL no longer has the attached search-attribution parameters mentioned in the issue #20659 (comment)
- Opened dev tool and confirmed URL no longer has the attached search-attribution parameters

Select Bing in settings Search result parameter Dev tool parameter
image image image

Verified with

Brave | 1.36.86 Chromium: 98.0.4758.87 (Official Build) beta (x86_64)
-- | --
Revision | e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS | macOS Version 12.2 (Build 21D49)

Reproduced the issue in both cases using 1.35.100 Chromium: 98.0.4758.87 (Official Build) (x86_64)

Case 1 Example Case 1 Example Case 2 Example Case 2 Example
1a 1b 2a 2b

Logged follow up issue #21085 for upgrade profiles using quick search (:b) for Bing where Bing is not default SE still having the parameters in the URL.

Clean profile checks:

Case 1 - Search using bing search keyword :b - PASSED
       - Clean profile 1.36.x
       - Enter the `Bing` search keyword  `:b` in the URL bar and hit TAB 
       - Enter any string and confirmed URL no longer has the attached search-attribution parameters mentioned in the issue https://github.com/brave/brave-browser/issues/20659#issue-1113124586
       - Opened dev tool and confirmed URL no longer has the attached search-attribution parameters
Example Example Example
1a 1b 1c
Case 2 - Search using bing search engine via brave://settings/search - PASSED
       - Clean profile 1.36.x
       - Select `Bing` as default search engine from brave://settings/search
       - Enter any string and confirmed URL no longer has the attached search-attribution parameters mentioned in the issue https://github.com/brave/brave-browser/issues/20659#issue-1113124586
       - Opened dev tool and confirmed URL no longer has the attached search-attribution parameters
Example Example Example
2a 2b 2c

Verified PASSED using

Brave 1.36.93 Chromium: 98.0.4758.87 (Official Build) beta (64-bit)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS Linux

Clean profile checks:

Case 1 - Search using bing search keyword :b - PASSED
       - Clean profile 1.36.x
       - Enter the `Bing` search keyword  `:b` in the URL bar and hit TAB 
       - Enter any string and confirmed URL no longer has the attached search-attribution parameters mentioned in the issue https://github.com/brave/brave-browser/issues/20659#issue-1113124586
       - Opened dev tool and confirmed URL no longer has the attached search-attribution parameters
Example Example Example
Screen Shot 2022-02-14 at 9 24 30 AM Screen Shot 2022-02-14 at 9 24 54 AM Screen Shot 2022-02-14 at 9 26 20 AM
Case 2 - Search using bing search engine via brave://settings/search - PASSED
       - Clean profile 1.36.x
       - Select `Bing` as default search engine from brave://settings/search
       - Enter any string and confirmed URL no longer has the attached search-attribution parameters mentioned in the issue https://github.com/brave/brave-browser/issues/20659#issue-1113124586
       - Opened dev tool and confirmed URL no longer has the attached search-attribution parameters
Example Example Example
Screen Shot 2022-02-14 at 9 27 34 AM Screen Shot 2022-02-14 at 9 27 47 AM Screen Shot 2022-02-14 at 9 28 36 AM

@Uni-verse
Copy link
Contributor

Uni-verse commented Feb 7, 2022

Verification PASSED on Samsung Galaxy S21 running Android 12 using build version:

1.36.86, Chromium 98.0.4758.87

#20659 (comment)

  • Verified search attribution is removed when setting Bing as default search engine
  • Verified searching in private mode removes attribution

Screenshot_20220208-035230_Brave - Beta


Verification passed on Samsung Tab A with Android 10 running 1.36.100 x64 beta build

  • Verified CHROMN attribution is removed when Bing is set as default browser
  • Verified on both normal and private tab
Normal Tab Private Tab
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants