Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-contribute percentages are incorrect as they are not adding up to 100% when "Show non-verified sites in list" is toggled off in brave://settings/rewards #21065

Closed
MadhaviSeelam opened this issue Feb 11, 2022 · 3 comments
Assignees
Labels
bug closed/by-author feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes

Comments

@MadhaviSeelam
Copy link

MadhaviSeelam commented Feb 11, 2022

Description

Auto-contribute percentages are incorrect as they are not adding up to 100% when "Show non-verified sites in list" is toggled off in brave://settings/rewards

Steps to Reproduce

  1. Clean profile
  2. Launch Brave
  3. Skip welcome tour
  4. Change to staging env in QA prefs
  5. Enable Rewards
  6. Open a non- verified site - https://twitter.com/
  7. Stay on the site to record the attention percentage (80%)
  8. Visited a verified site -twitter.com/emerick
  9. Recorded percentage (17%)
  10. Visited one more non verified site (cnn.com)
  11. Recorded percentage (7%)
  12. Toggle off "Show non-verified sites in list" in brave://settings/rewards
  13. Click Brave Rewards in the navbar

Actual result:

Emerick on Twitter (twitter.com/emerick) percentage was 13%

Example Example Example
Screenshot 1- verified and non verified sites add up to 100 percent screenshot 2 -toggle off settingsrewards screenshot 3- auto-contribute percentage was incorrect

Expected result:

Emerick on Twitter (twitter.com/emerick) should display 100%

Reproduces how often:

Easily

Brave version (brave://version info)

Brave 1.35.101 Chromium: 98.0.4758.87 (Official Build) (64-bit)
Revision e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS  Windows 11 Version 21H2 (Build 22000.493)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? N/A
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Miscellaneous Information:

cc @Miyayes @brave/legacy_qa

@Miyayes Miyayes added OS/Android Fixes related to Android browser functionality bug labels Feb 12, 2022
@zenparsing
Copy link

Note that the percentages appear to readjust when setting is changed from the rewards page.

@zenparsing zenparsing self-assigned this Feb 16, 2022
@zenparsing zenparsing added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 16, 2022
@LaurenWags
Copy link
Member

@MadhaviSeelam I believe the comment from @zenparsing under #21065 (comment) is correct based on our discussion. However, could you double check when you have a moment?

@MadhaviSeelam
Copy link
Author

This is working as expected i.e. Auto-contribute percentages are correct and adding up to 100% if "Show non-verified sites in list check box is unchecked in Auto-Contribute Settings in Brave://rewards. Closing the issue.

Example

Verified list -100%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug closed/by-author feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes
Projects
None yet
Development

No branches or pull requests

4 participants